Changeset 54783 for branches/6.1

Timestamp:

11/10/2022 02:19:05 AM (4 years ago)

Author:

peterwilsoncc

Message:

Posts, Post Types: Revert get_page_by_title()'s use of WP_Query.

Revert to legacy database query in get_pages_by_title(). Due to the lack of orderby clause in the previous database query, it is not possible to gain consistent results by converting the function to a WP_Query wrapper.

Reverts [54271, 54242, 54234].

Props Bjorn2404, 10upsimon, dilipbheda, mukesh27, spacedmonkey, TimothyBlynJacobs, rjasdfiii, stentibbing, pbiron, pento.
Merges [54782] to the 6.1 branch.
Fixes #57039, #56991.
See #57041.

Location:

branches/6.1

Files:

• . (modified) (1 prop)
• src/wp-includes/post.php (modified) (2 diffs)
• tests/phpunit/tests/post/getPageByTitle.php (deleted)

branches/6.1/src/wp-includes/post.php

@@ -5767 +5767 @@
  * @since 3.0.0 The `$post_type` parameter was added.
  *
+ * @global wpdb $wpdb WordPress database abstraction object.
+ *
  * @param string       $page_title Page title.
  * @param string       $output     Optional. The required return type. One of OBJECT, ARRAY_A, or ARRAY_N, which
@@ -5775 +5777 @@
  */
 function get_page_by_title( $page_title, $output = OBJECT, $post_type = 'page' ) {
-        $args  = array(
-                'title'                  => $page_title,
-                'post_type'              => $post_type,
-                'post_status'            => get_post_stati(),
-                'posts_per_page'         => 1,
-                'update_post_term_cache' => false,
-                'update_post_meta_cache' => false,
-                'no_found_rows'          => true,
-                'orderby'                => 'post_date ID',
-                'order'                  => 'ASC',
-        );
-        $query = new WP_Query( $args );
-        $pages = $query->posts;
-
-        if ( empty( $pages ) ) {
-                return null;
-        }
-
-        return get_post( $pages[0], $output );
+        global $wpdb;
+
+        if ( is_array( $post_type ) ) {
+                $post_type           = esc_sql( $post_type );
+                $post_type_in_string = "'" . implode( "','", $post_type ) . "'";
+                $sql                 = $wpdb->prepare(
+                        "
+                        SELECT ID
+                        FROM $wpdb->posts
+                        WHERE post_title = %s
+                        AND post_type IN ($post_type_in_string)
+                ",
+                        $page_title
+                );
+        } else {
+                $sql = $wpdb->prepare(
+                        "
+                        SELECT ID
+                        FROM $wpdb->posts
+                        WHERE post_title = %s
+                        AND post_type = %s
+                ",
+                        $page_title,
+                        $post_type
+                );
+        }
+
+        $page = $wpdb->get_var( $sql );
+
+        if ( $page ) {
+                return get_post( $page, $output );
+        }
+
+        return null;
 }