Changeset 54785 for trunk/tests/phpunit/tests/canonical.php

Timestamp:

11/10/2022 02:59:56 AM (4 years ago)

Author:

peterwilsoncc

Message:

Canonical: Protect against error for term not exists queries.

Prevent term NOT EXISTS queries causing redirect_canonical() to throw a fatal error in PHP 8 and above, or a warning in earlier versions.

This ensures the tax_query's terms property both exists and is countable before attempting to count it.

Props codesdnc, SergeyBiryukov, kadamwhite, costdev, miguelaxcar.
Fixes #55955.

File:

• trunk/tests/phpunit/tests/canonical.php (modified) (1 diff)

trunk/tests/phpunit/tests/canonical.php

@@ -376 +376 @@
                 delete_option( 'page_on_front' );
         }
+
+        /**
+         * Ensure NOT EXISTS queries do not trigger not-countable or undefined array key errors.
+         *
+         * @ticket 55955
+         */
+        public function test_feed_canonical_with_not_exists_query() {
+                // Set a NOT EXISTS tax_query on the global query.
+                $global_query        = $GLOBALS['wp_query'];
+                $GLOBALS['wp_query'] = new WP_Query(
+                        array(
+                                'post_type' => 'post',
+                                'tax_query' => array(
+                                        array(
+                                                'taxonomy' => 'post_format',
+                                                'operator' => 'NOT EXISTS',
+                                        ),
+                                ),
+                        )
+                );
+
+                $url = redirect_canonical( get_term_feed_link( self::$terms['/category/parent/'] ), false );
+                // Restore original global.
+                $GLOBALS['wp_query'] = $global_query;
+
+                $this->assertNull( $url );
+        }
 }