Changeset 54817 for trunk/src/wp-includes/class-wp-theme-json-resolver.php

Timestamp:

11/11/2022 04:24:47 PM (2 years ago)

Author:

spacedmonkey

Message:

Themes: Reduce usage of wp_get_theme function.

Calling the wp_get_theme function creates a instance of the WP_Theme class. This can be a performance issue, if all you need is one property of the class instance. This change replaces the usage of wp_get_theme()->get_stylesheet() with get_stylesheet() to improve performance.

Props spacedmonkey, flixos90, peterwilsoncc, desrosj.
Fixes #57057.

File:

• trunk/src/wp-includes/class-wp-theme-json-resolver.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-theme-json-resolver.php

@@ -244 +244 @@
         }
 
-        $options = wp_parse_args( $options, array( 'with_supports' => true ) );
+        $options  = wp_parse_args( $options, array( 'with_supports' => true ) );
 
         if ( null === static::$theme || ! static::has_same_registered_blocks( 'theme' ) ) {
             $theme_json_file = static::get_file_path_from_theme( 'theme.json' );
+            $wp_theme        = wp_get_theme();
             if ( '' !== $theme_json_file ) {
                 $theme_json_data = static::read_json_file( $theme_json_file );
-                $theme_json_data = static::translate( $theme_json_data, wp_get_theme()->get( 'TextDomain' ) );
+                $theme_json_data = static::translate( $theme_json_data, $wp_theme->get( 'TextDomain' ) );
             } else {
                 $theme_json_data = array();
@@ -266 +267 @@
             static::$theme   = new WP_Theme_JSON( $theme_json_data );
 
-            if ( wp_get_theme()->parent() ) {
+            if ( $wp_theme->parent() ) {
                 // Get parent theme.json.
                 $parent_theme_json_file = static::get_file_path_from_theme( 'theme.json', true );
                 if ( '' !== $parent_theme_json_file ) {
                     $parent_theme_json_data = static::read_json_file( $parent_theme_json_file );
-                    $parent_theme_json_data = static::translate( $parent_theme_json_data, wp_get_theme()->parent()->get( 'TextDomain' ) );
+                    $parent_theme_json_data = static::translate( $parent_theme_json_data, $wp_theme->parent()->get( 'TextDomain' ) );
                     $parent_theme           = new WP_Theme_JSON( $parent_theme_json_data );