Make WordPress Core


Ignore:
Timestamp:
11/16/2022 07:32:57 PM (20 months ago)
Author:
desrosj
Message:

Build/Test Tools: Various minor GitHub Action improvements.

This applies several types of improvements to GitHub Action workflows:

  • Updates to inline documentation to ensure accuracy.
  • Removal of repetitive or unnecessary debug logging.
  • Reorganization of some steps to have configuration steps towards the beginning of jobs.
  • Step name updates for consistency across workflows.

Props desrosj, jrf.
See #56793.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/.github/workflows/coding-standards.yml

    r54750 r54851  
    4949  # - Checks out the repository.
    5050  # - Sets up PHP.
    51   # - Logs debug information.
    5251  # - Configures caching for PHPCS scans.
    53   # - Installs Composer dependencies (use cache if possible).
     52  # - Installs Composer dependencies.
    5453  # - Make Composer packages available globally.
    55   # - Logs PHP_CodeSniffer debug information.
    5654  # - Runs PHPCS on the full codebase with warnings suppressed.
     55  # - Generate a report for displaying issues as pull request annotations.
    5756  # - Runs PHPCS on the `tests` directory without warnings suppressed.
     57  # - Generate a report for displaying `test` directory issues as pull request annotations.
    5858  # - Ensures version-controlled files are not modified or deleted.
     59
    5960  phpcs:
    6061    name: PHP coding standards
     
    7475          tools: composer, cs2pr
    7576
    76       - name: Log debug information
    77         run: |
    78           php --version
    79           composer --version
    80 
    8177      # This date is used to ensure that the PHPCS cache is cleared at least once every week.
    8278      # http://man7.org/linux/man-pages/man1/date.1.html
     
    9995        run: echo "${PWD}/vendor/bin" >> $GITHUB_PATH
    10096
    101       - name: Log PHPCS debug information
    102         run: phpcs -i
    103 
    10497      - name: Run PHPCS on all Core files
    10598        id: phpcs-core
     
    127120  # Performs the following steps:
    128121  # - Checks out the repository.
     122  # - Sets up Node.js.
    129123  # - Logs debug information about the GitHub Action runner.
    130   # - Installs Node.js.
    131   # - Logs updated debug information.
    132   # _ Installs npm dependencies.
     124  # - Installs npm dependencies.
    133125  # - Run the WordPress JSHint checks.
    134126  # - Ensures version-controlled files are not modified or deleted.
     
    145137        uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
    146138
     139      - name: Set up Node.js
     140        uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
     141        with:
     142          node-version-file: '.nvmrc'
     143          cache: npm
     144
    147145      - name: Log debug information
    148146        run: |
     
    152150          svn --version
    153151
    154       - name: Install Node.js
    155         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
    156         with:
    157           node-version-file: '.nvmrc'
    158           cache: npm
    159 
    160       - name: Log debug information
    161         run: |
    162           npm --version
    163           node --version
    164 
    165       - name: Install Dependencies
     152      - name: Install npm Dependencies
    166153        run: npm ci
    167154
Note: See TracChangeset for help on using the changeset viewer.