Changeset 54851 for trunk/.github/workflows/phpunit-tests.yml

Timestamp:

11/16/2022 07:32:57 PM (2 years ago)

Author:

desrosj

Message:

Build/Test Tools: Various minor GitHub Action improvements.

This applies several types of improvements to GitHub Action workflows:

• Updates to inline documentation to ensure accuracy.
• Removal of repetitive or unnecessary debug logging.
• Reorganization of some steps to have configuration steps towards the beginning of jobs.
• Step name updates for consistency across workflows.

Props desrosj, jrf.
See #56793.

File:

• trunk/.github/workflows/phpunit-tests.yml (modified) (6 diffs)

trunk/.github/workflows/phpunit-tests.yml

@@ -37 +37 @@
   # Performs the following steps:
   # - Sets environment variables.
-  # - Sets up the environment variables needed for testing with memcached (if desired).
-  # - Installs Node.js.
+  # - Checks out the repository.
+  # - Sets up Node.js.
+  # - Logs general debug information about the runner.
   # - Installs npm dependencies
   # - Configures caching for Composer.
@@ -44 +45 @@
   # - Logs Docker debug information (about the Docker installation within the runner).
   # - Starts the WordPress Docker container.
-  # - Logs general debug information about the runner.
   # - Logs the running Docker containers.
-  # - Logs debug information from inside the WordPress Docker container.
   # - Logs debug information about what's installed within the WordPress Docker containers.
   # - Install WordPress within the Docker container.
@@ -52 +51 @@
   # - Ensures version-controlled files are not modified or deleted.
   # - Checks out the WordPress Test reporter repository.
-  # - Reconnect the directory to the Git repository.
   # - Submit the test results to the WordPress.org host test results.
   test-php:
@@ -109 +107 @@
         uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # v3.1.0
 
-      - name: Install Node.js
+      - name: Set up Node.js
         uses: actions/setup-node@8c91899e586c5b171469028077307d293428b516 # v3.5.1
         with:
@@ -115 +113 @@
           cache: npm
 
-      - name: Install Dependencies
+      - name: General debug information
+        run: |
+          npm --version
+          node --version
+          curl --version
+          git --version
+          svn --version
+
+      - name: Install npm dependencies
         run: npm ci
 
@@ -155 +161 @@
         run: |
           npm run env:start
-
-      - name: General debug information
-        run: |
-          npm --version
-          node --version
-          curl --version
-          git --version
-          svn --version
 
       - name: Log running Docker containers