Make WordPress Core


Ignore:
Timestamp:
11/16/2022 08:55:34 PM (21 months ago)
Author:
desrosj
Message:

Build/Test Tools: Add additional details why MacOS jobs are separate.

This adds additional inline context as to why the MacOS job is separate from the Windows and Ubuntu ones in the Test npm workflow.

While it is preferable to combine all of these to avoid repeated code, there is currently no way to determine the runner’s OS within the if workflow key.

MacOS jobs use GitHub Action minutes at by a multiple of 10. Being more strict about when to run these jobs ensures minutes are not unintentionally consumed within private forks and mirrors.

See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for more details.

See #56793.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/.github/workflows/test-npm.yml

    r54851 r54852  
    105105  # This avoids unintentionally consuming excessive minutes, as MacOS jobs consume minutes at a 10x rate.
    106106  #
     107  # The `matrix` and `runner` contexts are not available for use within `if` expressions. So there is
     108  # currently no way to determine the OS being used on a given job.
     109  # See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability.
     110  #
    107111  # Performs the following steps:
    108112  # - Checks out the repository.
Note: See TracChangeset for help on using the changeset viewer.