Changeset 54857

Timestamp:

11/18/2022 03:19:07 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Users: Add missing escaping on the Add New User screen.

While the $type and $label variables are set to values that do not currently require escaping, this may change in the future, so it is preferable to add the escaping as a defensive coding measure.

Follow-up to [16294], [29030].

Props monzuralam, rudlinkon, hztyfoon, peterwilsoncc.
Fixes #57133.

File:

• trunk/src/wp-admin/user-new.php (modified) (1 diff)

trunk/src/wp-admin/user-new.php

@@ -443 +443 @@
 <table class="form-table" role="presentation">
     <tr class="form-field form-required">
-        <th scope="row"><label for="adduser-email"><?php echo $label; ?></label></th>
-        <td><input name="email" type="<?php echo $type; ?>" id="adduser-email" class="wp-suggest-user" value="" /></td>
+        <th scope="row"><label for="adduser-email"><?php echo esc_html( $label ); ?></label></th>
+        <td><input name="email" type="<?php echo esc_attr( $type ); ?>" id="adduser-email" class="wp-suggest-user" value="" /></td>
     </tr>
     <tr class="form-field">