Changeset 54858

Timestamp:

11/19/2022 03:40:11 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Fix WPCS issues in wp-admin/install-helper.php.

This commit adds inline comments instructing PHPCS to ignore some lines for database queries. An explanation is provided with each instruction.

This resolves a few WPCS warnings along the lines of:

Use placeholders and $wpdb->prepare(); found interpolated variable $table_name at "DESC $table_name"

Follow-up to [236], [265], [5778].

Props jipmoors, costdev, jrf, SergeyBiryukov.
Fixes #43761.

File:

• trunk/src/wp-admin/install-helper.php (modified) (5 diffs)

trunk/src/wp-admin/install-helper.php

@@ -60 +60 @@
 
         // Didn't find it, so try to create it.
+        // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared -- No applicable variables for this query.
         $wpdb->query( $create_ddl );
 
@@ -89 +90 @@
         global $wpdb;
 
+        // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared -- Cannot be prepared. Fetches columns for table names.
         foreach ( $wpdb->get_col( "DESC $table_name", 0 ) as $column ) {
             if ( $column === $column_name ) {
@@ -96 +98 @@
 
         // Didn't find it, so try to create it.
+        // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared -- No applicable variables for this query.
         $wpdb->query( $create_ddl );
 
         // We cannot directly tell that whether this succeeded!
+        // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared -- Cannot be prepared. Fetches columns for table names.
         foreach ( $wpdb->get_col( "DESC $table_name", 0 ) as $column ) {
             if ( $column === $column_name ) {
@@ -124 +128 @@
     global $wpdb;
 
+    // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared -- Cannot be prepared. Fetches columns for table names.
     foreach ( $wpdb->get_col( "DESC $table_name", 0 ) as $column ) {
         if ( $column === $column_name ) {
 
             // Found it, so try to drop it.
+            // phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared -- No applicable variables for this query.
             $wpdb->query( $drop_ddl );
 
             // We cannot directly tell that whether this succeeded!
+            // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared -- Cannot be prepared. Fetches columns for table names.
             foreach ( $wpdb->get_col( "DESC $table_name", 0 ) as $column ) {
                 if ( $column === $column_name ) {
@@ -175 +182 @@
     global $wpdb;
 
-    $diffs   = 0;
+    $diffs = 0;
+
+    // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared -- Cannot be prepared. Fetches columns for table names.
     $results = $wpdb->get_results( "DESC $table_name" );