Changeset 54870

Timestamp:

11/24/2022 02:16:18 PM (22 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use HOUR_IN_SECONDS where appropriate.

This aims to clarify the time units for some time offset values.

Follow-up to [21996], [23823], [40108], [41626].

See #56791.

Location:

trunk/src/wp-includes

Files:

• customize/class-wp-customize-date-time-control.php (modified) (1 diff)
• rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• revision.php (modified) (1 diff)

trunk/src/wp-includes/customize/class-wp-customize-date-time-control.php

@@ -235 +235 @@
             if ( $tz ) {
                 $now                   = new DateTime( 'now', $tz );
-                $formatted_gmt_offset  = $this->format_gmt_offset( $tz->getOffset( $now ) / 3600 );
+                $formatted_gmt_offset  = $this->format_gmt_offset( $tz->getOffset( $now ) / HOUR_IN_SECONDS );
                 $tz_name               = str_replace( '_', ' ', $tz->getName() );
                 $timezone_info['abbr'] = $now->format( 'T' );

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1798 +1798 @@
              */
             if ( '0000-00-00 00:00:00' === $post->post_modified_gmt ) {
-                $post_modified_gmt = gmdate( 'Y-m-d H:i:s', strtotime( $post->post_modified ) - ( get_option( 'gmt_offset' ) * 3600 ) );
+                $post_modified_gmt = gmdate( 'Y-m-d H:i:s', strtotime( $post->post_modified ) - ( get_option( 'gmt_offset' ) * HOUR_IN_SECONDS ) );
             } else {
                 $post_modified_gmt = $post->post_modified_gmt;

trunk/src/wp-includes/revision.php

@@ -860 +860 @@
         }
 
-        if ( $locked > $now - 3600 ) {
+        if ( $locked > $now - HOUR_IN_SECONDS ) {
             // Lock is not too old: some other process may be upgrading this post. Bail.
             return false;