Changeset 54895

Timestamp:

11/29/2022 08:58:26 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Always use strict type check for in_array().

This fixes the currently flagged WordPress.PHP.StrictInArray.MissingTrueStrict issues:

• Not using strict comparison for in_array; supply true for third argument.

These all do comparisons with strings, so all the more reason why it is imperative that a strict comparison is used.

Follow-up to [47550], [47557], [54155], [53480].

Props jrf.
See #56791.

Location:

trunk/src/wp-includes

Files:

• class-wp-block-type.php (modified) (3 diffs)
• pluggable.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-block-type.php

@@ -300 +300 @@
          */
         public function __get( $name ) {
-                if ( ! in_array( $name, $this->deprecated_properties ) ) {
+                if ( ! in_array( $name, $this->deprecated_properties, true ) ) {
                         return;
                 }
@@ -328 +328 @@
          */
         public function __isset( $name ) {
-                if ( ! in_array( $name, $this->deprecated_properties ) ) {
+                if ( ! in_array( $name, $this->deprecated_properties, true ) ) {
                         return false;
                 }
@@ -347 +347 @@
          */
         public function __set( $name, $value ) {
-                if ( ! in_array( $name, $this->deprecated_properties ) ) {
+                if ( ! in_array( $name, $this->deprecated_properties, true ) ) {
                         $this->{$name} = $value;
                         return;

trunk/src/wp-includes/pluggable.php

@@ -2880 +2880 @@
                 }
 
-                if ( in_array( $args['decoding'], array( 'async', 'sync', 'auto' ) ) && ! preg_match( '/\bdecoding\s*=/', $extra_attr ) ) {
+                if ( in_array( $args['decoding'], array( 'async', 'sync', 'auto' ), true ) && ! preg_match( '/\bdecoding\s*=/', $extra_attr ) ) {
                         if ( ! empty( $extra_attr ) ) {
                                 $extra_attr .= ' ';