Changeset 54917

Timestamp:

11/30/2022 06:30:57 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Fix a non-snake_case function name in WP_Block tests.

As the filter is only intended for a single test, it can be converted to a closure instead of being declared as a function in the global namespace. The remove_filter() part is redundant, as WP_UnitTestCase_Base saves the state of filter-related globals at set_up() and restores them on tear_down().

Follow-up to [54175].

Props jrf, SergeyBiryukov.
See #56791.

File:

• trunk/tests/phpunit/tests/blocks/wpBlock.php (modified) (1 diff)

trunk/tests/phpunit/tests/blocks/wpBlock.php

@@ -605 +605 @@
                 );
                 $block         = new WP_Block( $parsed_block, $context, $this->registry );
-                function filterQuery( $query, $block, $page ) {
-                        $query['post_type'] = 'book';
-                        return $query;
-                }
-                add_filter( 'query_loop_block_query_vars', 'filterQuery', 10, 3 );
+
+                add_filter(
+                        'query_loop_block_query_vars',
+                        static function( $query, $block, $page ) {
+                                $query['post_type'] = 'book';
+                                return $query;
+                        },
+                        10,
+                        3
+                );
+
                 $query = build_query_vars_from_query_block( $block, 1 );
-                remove_filter( 'query_loop_block_query_vars', 'filterQuery' );
                 $this->assertSame(
                         $query,