Changeset 54920

Timestamp:

12/01/2022 03:41:12 PM (23 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Remove a one-time $loading variable in get_avatar().

This aims to bring consistency between two similar code fragments.

Follow-up to [47554], [53480], [54895].

See #56791.

File:

• trunk/src/wp-includes/pluggable.php (modified) (1 diff)

trunk/src/wp-includes/pluggable.php

@@ -2868 +2868 @@
         }
 
-        // Add `loading` attribute.
+        // Add `loading` and `decoding` attributes.
         $extra_attr = $args['extra_attr'];
-        $loading    = $args['loading'];
-
-        if ( in_array( $loading, array( 'lazy', 'eager' ), true ) && ! preg_match( '/\bloading\s*=/', $extra_attr ) ) {
+
+        if ( in_array( $args['loading'], array( 'lazy', 'eager' ), true )
+            && ! preg_match( '/\bloading\s*=/', $extra_attr )
+        ) {
             if ( ! empty( $extra_attr ) ) {
                 $extra_attr .= ' ';
             }
 
-            $extra_attr .= "loading='{$loading}'";
-        }
-
-        if ( in_array( $args['decoding'], array( 'async', 'sync', 'auto' ), true ) && ! preg_match( '/\bdecoding\s*=/', $extra_attr ) ) {
+            $extra_attr .= "loading='{$args['loading']}'";
+        }
+
+        if ( in_array( $args['decoding'], array( 'async', 'sync', 'auto' ), true )
+            && ! preg_match( '/\bdecoding\s*=/', $extra_attr )
+        ) {
             if ( ! empty( $extra_attr ) ) {
                 $extra_attr .= ' ';
             }
+
             $extra_attr .= "decoding='{$args['decoding']}'";
         }