Changeset 54938 for trunk/src/wp-includes/l10n.php

Timestamp:

12/06/2022 01:01:16 PM (22 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/l10n.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $string parameter to $text in before_last_bar().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:

• trunk/src/wp-includes/l10n.php (modified) (1 diff)

trunk/src/wp-includes/l10n.php

@@ -223 +223 @@
  * @since 2.8.0
  *
- * @param string $string A pipe-delimited string.
- * @return string Either $string or everything before the last pipe.
- */
-function before_last_bar( $string ) {
-    $last_bar = strrpos( $string, '|' );
+ * @param string $text A pipe-delimited string.
+ * @return string Either $text or everything before the last pipe.
+ */
+function before_last_bar( $text ) {
+    $last_bar = strrpos( $text, '|' );
     if ( false === $last_bar ) {
-        return $string;
+        return $text;
     } else {
-        return substr( $string, 0, $last_bar );
+        return substr( $text, 0, $last_bar );
     }
 }