Make WordPress Core

Changeset 54946


Ignore:
Timestamp:
12/07/2022 02:30:17 PM (18 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/ms-deprecated.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $string parameter to $email_or_login in get_user_id_from_string().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/ms-deprecated.php

    r54283 r54946  
    335335 * @see get_user_by()
    336336 *
    337  * @param string $string Either an email address or a login.
     337 * @param string $email_or_login Either an email address or a login.
    338338 * @return int
    339339 */
    340 function get_user_id_from_string( $string ) {
     340function get_user_id_from_string( $email_or_login ) {
    341341    _deprecated_function( __FUNCTION__, '3.6.0', 'get_user_by()' );
    342342
    343     if ( is_email( $string ) )
    344         $user = get_user_by( 'email', $string );
    345     elseif ( is_numeric( $string ) )
    346         return $string;
     343    if ( is_email( $email_or_login ) )
     344        $user = get_user_by( 'email', $email_or_login );
     345    elseif ( is_numeric( $email_or_login ) )
     346        return $email_or_login;
    347347    else
    348         $user = get_user_by( 'login', $string );
     348        $user = get_user_by( 'login', $email_or_login );
    349349
    350350    if ( $user )
Note: See TracChangeset for help on using the changeset viewer.