Make WordPress Core

Changeset 54947


Ignore:
Timestamp:
12/07/2022 09:17:52 PM (18 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/ms-site.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit:

  • Renames the $public parameter to $is_public in wp_update_blog_public_option_on_site_update().
  • Amends the $value parameter of the update_blog_public filter for consistency.

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/ms-site.php

    r53944 r54947  
    12351235         * @since MU (3.0.0)
    12361236         *
    1237          * @param int    $site_id Site ID.
    1238          * @param string $value   The value of the site status.
     1237         * @param int    $site_id   Site ID.
     1238         * @param string $is_public Whether the site is public. A numeric string,
     1239         *                          for compatibility reasons. Accepts '1' or '0'.
    12391240         */
    12401241        do_action( 'update_blog_public', $site_id, $new_site->public );
     
    12611262 * @since 5.1.0
    12621263 *
    1263  * @param int    $site_id Site ID.
    1264  * @param string $public  The value of the site status.
    1265  */
    1266 function wp_update_blog_public_option_on_site_update( $site_id, $public ) {
     1264 * @param int    $site_id   Site ID.
     1265 * @param string $is_public Whether the site is public. A numeric string,
     1266 *                          for compatibility reasons. Accepts '1' or '0'.
     1267 */
     1268function wp_update_blog_public_option_on_site_update( $site_id, $is_public ) {
    12671269
    12681270    // Bail if the site's database tables do not exist (yet).
     
    12711273    }
    12721274
    1273     update_blog_option( $site_id, 'blog_public', $public );
     1275    update_blog_option( $site_id, 'blog_public', $is_public );
    12741276}
    12751277
Note: See TracChangeset for help on using the changeset viewer.