Make WordPress Core

Changeset 54951


Ignore:
Timestamp:
12/08/2022 07:29:51 PM (17 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/php-compat/readonly.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $readonly and $echo parameters to $readonly_value and $display in readonly().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/php-compat/readonly.php

    r53086 r54951  
    2525 * @see wp_readonly()
    2626 *
    27  * @param mixed $readonly One of the values to compare.
    28  * @param mixed $current  Optional. The other value to compare if not just true.
    29  *                        Default true.
    30  * @param bool  $echo     Optional. Whether to echo or just return the string.
    31  *                        Default true.
     27 * @param mixed $readonly_value One of the values to compare.
     28 * @param mixed $current        Optional. The other value to compare if not just true.
     29 *                              Default true.
     30 * @param bool  $display        Optional. Whether to echo or just return the string.
     31 *                              Default true.
    3232 * @return string HTML attribute or empty string.
    3333 */
    34 function readonly( $readonly, $current = true, $echo = true ) {
     34function readonly( $readonly_value, $current = true, $display = true ) {
    3535    _deprecated_function( __FUNCTION__, '5.9.0', 'wp_readonly()' );
    36     return wp_readonly( $readonly, $current, $echo );
     36    return wp_readonly( $readonly_value, $current, $display );
    3737}
Note: See TracChangeset for help on using the changeset viewer.