Changeset 54952 for trunk/tests/phpunit/tests/pluggable/signatures.php

Timestamp:

12/09/2022 12:22:14 AM (23 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/pluggable.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit:

• Renames the $die parameter to $stop in check_ajax_referer().
• Renames the $default parameter to $fallback_url in wp_validate_redirect().
• Renames the $default parameter to $default_value in get_avatar().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:

• trunk/tests/phpunit/tests/pluggable/signatures.php (modified) (3 diffs)

trunk/tests/phpunit/tests/pluggable/signatures.php

@@ -174 +174 @@
                 'action'    => -1,
                 'query_arg' => false,
-                'die'       => true,
+                'stop'      => true,
             ),
             'wp_redirect'                     => array(
@@ -190 +190 @@
             'wp_validate_redirect'            => array(
                 'location',
-                'default' => '',
+                'fallback_url' => '',
             ),
             'wp_notify_postauthor'            => array(
@@ -232 +232 @@
             'get_avatar'                      => array(
                 'id_or_email',
-                'size'    => 96,
-                'default' => '',
-                'alt'     => '',
-                'args'    => null,
+                'size'          => 96,
+                'default_value' => '',
+                'alt'           => '',
+                'args'          => null,
             ),
             'wp_text_diff'                    => array(