Changeset 54973 for trunk/src/wp-admin/nav-menus.php

Timestamp:

12/14/2022 10:52:11 PM (2 years ago)

Author:

azaozz

Message:

Menus: Reset menu_item_parent to 0 when the parent is set to the item itself.

Props: peterwilsoncc, SergeyBiryukov, azaozz.
Fixes #57169.

File:

• trunk/src/wp-admin/nav-menus.php (modified) (4 diffs)

trunk/src/wp-admin/nav-menus.php

@@ -118 +118 @@
                             $parent_data                        = (array) $parent_object;
                             $menu_item_data['menu_item_parent'] = $parent_data['menu_item_parent'];
+
+                            // Reset invalid `menu_item_parent`.
+                            $menu_item_data = _wp_reset_invalid_menu_item_parent( $menu_item_data );
+
                             update_post_meta( $menu_item_data['ID'], '_menu_item_menu_item_parent', (int) $menu_item_data['menu_item_parent'] );
                         }
@@ -127 +131 @@
 
                         $menu_item_data['menu_item_parent'] = $next_item_data['ID'];
+
+                        // Reset invalid `menu_item_parent`.
+                        $menu_item_data = _wp_reset_invalid_menu_item_parent( $menu_item_data );
+
                         update_post_meta( $menu_item_data['ID'], '_menu_item_menu_item_parent', (int) $menu_item_data['menu_item_parent'] );
 
@@ -138 +146 @@
                 ) {
                     $menu_item_data['menu_item_parent'] = (int) get_post_meta( $menu_item_data['menu_item_parent'], '_menu_item_menu_item_parent', true );
+
+                    // Reset invalid `menu_item_parent`.
+                    $menu_item_data = _wp_reset_invalid_menu_item_parent( $menu_item_data );
+
                     update_post_meta( $menu_item_data['ID'], '_menu_item_menu_item_parent', (int) $menu_item_data['menu_item_parent'] );
                 }
@@ -248 +260 @@
                         // Just make it a child of the previous; keep the order.
                         $menu_item_data['menu_item_parent'] = (int) $orders_to_dbids[ $dbids_to_orders[ $menu_item_id ] - 1 ];
+
+                        // Reset invalid `menu_item_parent`.
+                        $menu_item_data = _wp_reset_invalid_menu_item_parent( $menu_item_data );
+
                         update_post_meta( $menu_item_data['ID'], '_menu_item_menu_item_parent', (int) $menu_item_data['menu_item_parent'] );
                         wp_update_post( $menu_item_data );