Changeset 54977 for branches/5.8/tests/phpunit/tests/http/base.php

Timestamp:

12/15/2022 04:23:56 AM (3 years ago)

Author:

peterwilsoncc

Message:

Built/Test tools, HTTP API: Refactor test for multiple location headers.

Remove wordpress.org as an external dependency testing WP_HTTP::handle_redirects().

This refactors and reenables an existing test to call the WP_HTTP::handle_redirects() method directly with a mocked array of HTTP headers containing multiple location headers.

The test is moved from the external-http group to the http test group as it no longer makes an HTTP request.

Follow up to [54955].

Props SergeyBiryukov, dd32, peterwilsoncc.
Merges [54968] to the 5.8 branch.
Fixes #57306.
See #56793.

Location:

branches/5.8

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/http/base.php (modified) (1 diff)

branches/5.8/tests/phpunit/tests/http/base.php

@@ -439 +439 @@
 
     /**
-     * Test HTTP Redirects with multiple Location headers specified.
-     *
-     * @ticket 16890
-     *
-     * @covers ::wp_remote_head
-     * @covers ::wp_remote_retrieve_header
-     * @covers ::wp_remote_get
-     * @covers ::wp_remote_retrieve_body
-     */
-    function test_multiple_location_headers() {
-        $url = 'http://api.wordpress.org/core/tests/1.0/redirection.php?multiple-location-headers=1';
-        $res = wp_remote_head( $url, array( 'timeout' => 30 ) );
-
-        $this->skipTestOnTimeout( $res );
-        $this->assertInternalType( 'array', wp_remote_retrieve_header( $res, 'location' ) );
-        $this->assertCount( 2, wp_remote_retrieve_header( $res, 'location' ) );
-
-        $res = wp_remote_get( $url, array( 'timeout' => 30 ) );
-
-        $this->skipTestOnTimeout( $res );
-        $this->assertSame( 'PASS', wp_remote_retrieve_body( $res ) );
-
-    }
-
-    /**
      * Test HTTP Cookie handling.
      *