Changeset 54997 for trunk/src/wp-includes/class-wp-http-requests-response.php

Timestamp:

12/15/2022 09:30:26 PM (22 months ago)

Author:

hellofromTonya

Message:

External Libraries: Update Requests library to version 2.0.0.

This is a major release and contains breaking changes.

Most important changes to be aware of for this release:

• All code is now namespaced. Though there is a full backward compatibility layer available and the old class names are still supported, using them will generate a deprecation notice (which can be silenced by plugins if they'd need to support multiple WP versions). See the ​upgrade guide for more details.
• A lot of classes have been marked final. This should generally not affect userland code as care has been taken to not apply the final keyword to classes which are known to be extended in userland code.
• Extensive input validation has been added to Requests. When Requests is used as documented though, this will be unnoticable.
• A new WpOrg\Requests\Requests::has_capabilities() method has been introduced which can be used to address #37708.
• A new WpOrg\Requests\Response::decode_body() method has been introduced which may be usable to simplify some of the WP native wrapper code.
• Remaining PHP 8.0 compatibility fixed (support for named parameters).
• PHP 8.1 compatibility.

Release notes: ​https://github.com/WordPress/Requests/releases/tag/v2.0.0

For a full list of changes in this update, see the Requests GitHub:
​https://github.com/WordPress/Requests/compare/v1.8.1...v2.0.0

This commit also resolves 2 blocking issues which previously caused the revert of [52244]:

• New Requests files are loaded into wp-includes/Requests/src/, matching the location of the library. In doing so, filesystems that are case-insensitive are not impacted (see #54582).
• Preload: During a Core update, the old Requests files are preloaded into memory before the update deletes the files. Preloading avoids fatal errors noted in #54562.

Follow-up to [50842], [51078], [52244], [52315], [52327], [52328].

Props jrf, schlessera, datagutten, wojsmol, dustinrue, soulseekah, szepeviktor. costdev, sergeybiryukov, peterwilsoncc, ironprogrammer, antonvlasenko, hellofromTonya, swissspidy, dd32, azaozz, TobiasBg, audrasjb.
Fixes #54504.
See #54582, #54562.

File:

• trunk/src/wp-includes/class-wp-http-requests-response.php (modified) (6 diffs)

trunk/src/wp-includes/class-wp-http-requests-response.php

@@ -9 +9 @@
 
 /**
- * Core wrapper object for a Requests_Response for standardisation.
+ * Core wrapper object for a WpOrg\Requests\Response for standardisation.
  *
  * @since 4.6.0
@@ -20 +20 @@
      *
      * @since 4.6.0
-     * @var Requests_Response
+     * @var \WpOrg\Requests\Response
      */
     protected $response;
@@ -37 +37 @@
      * @since 4.6.0
      *
-     * @param Requests_Response $response HTTP response.
-     * @param string            $filename Optional. File name. Default empty.
+     * @param \WpOrg\Requests\Response $response HTTP response.
+     * @param string                   $filename Optional. File name. Default empty.
      */
-    public function __construct( Requests_Response $response, $filename = '' ) {
+    public function __construct( WpOrg\Requests\Response $response, $filename = '' ) {
         $this->response = $response;
         $this->filename = $filename;
@@ -50 +50 @@
      * @since 4.6.0
      *
-     * @return Requests_Response HTTP response.
+     * @return WpOrg\Requests\Response HTTP response.
      */
     public function get_response_object() {
@@ -61 +61 @@
      * @since 4.6.0
      *
-     * @return \Requests_Utility_CaseInsensitiveDictionary Map of header name to header value.
+     * @return \WpOrg\Requests\Utility\CaseInsensitiveDictionary Map of header name to header value.
      */
     public function get_headers() {
         // Ensure headers remain case-insensitive.
-        $converted = new Requests_Utility_CaseInsensitiveDictionary();
+        $converted = new WpOrg\Requests\Utility\CaseInsensitiveDictionary();
 
         foreach ( $this->response->headers->getAll() as $key => $value ) {
@@ -86 +86 @@
      */
     public function set_headers( $headers ) {
-        $this->response->headers = new Requests_Response_Headers( $headers );
+        $this->response->headers = new WpOrg\Requests\Response\Headers( $headers );
     }