Changeset 55010 for trunk/tests/phpunit/tests/l10n/wpTextdomainRegistry.php

Timestamp:

12/20/2022 03:10:35 PM (2 years ago)

Author:

swissspidy

Message:

I18N: Change how WP_Textdomain_Registry caches translation information.

WP_Textdomain_Registry was introduced in [53874] and later adjusted in [54682] to store text domains and their language directory paths, addressing issues with just-in-time loading of textdomains when using locale switching and load_*_textdomain() functions.

This change improves how the class stores information about all existing MO files on the site, addressing an issue where translations are not loaded after calling switch_to_locale().

Props johnbillion, ocean90, SergeyBiryukov.
Fixes #57116.

File:

• trunk/tests/phpunit/tests/l10n/wpTextdomainRegistry.php (modified) (2 diffs)

trunk/tests/phpunit/tests/l10n/wpTextdomainRegistry.php

@@ -29 +29 @@
         $reflection_property->setAccessible( true );
 
-        $this->assertNull(
+        $this->assertEmpty(
             $reflection_property->getValue( $this->instance ),
             'Cache not empty by default'
@@ -76 +76 @@
             $reflection_property->getValue( $this->instance ),
             'Default plugins path missing from cache'
-        );
-    }
-
-    /**
-     * @covers ::get_path_from_lang_dir
-     */
-    public function test_get_does_not_check_themes_directory_for_plugin() {
-        $reflection          = new ReflectionClass( $this->instance );
-        $reflection_property = $reflection->getProperty( 'cached_mo_files' );
-        $reflection_property->setAccessible( true );
-
-        $this->instance->get( 'internationalized-plugin', 'de_DE' );
-
-        $this->assertArrayHasKey(
-            WP_LANG_DIR . '/plugins',
-            $reflection_property->getValue( $this->instance ),
-            'Default plugins path missing from cache'
-        );
-        $this->assertArrayNotHasKey(
-            WP_LANG_DIR . '/themes',
-            $reflection_property->getValue( $this->instance ),
-            'Default themes path should not be in cache'
         );
     }