Changeset 55019 for trunk/tests/phpunit/tests/post/wpInsertPost.php

Timestamp:

12/28/2022 02:07:16 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Bring some consistency to creating and updating objects in factory classes.

In various unit test factory classes, some of the create_object() and update_object() methods returned a WP_Error object on failure, while a few others were documented to do so, but did not in practice, instead returning the value 0 or false, or not accounting for a failure at all.

This commit aims to handle this in a consistent way by updating the methods to always return the object ID on success and a WP_Error object on failure.

Includes:

• Updating and correcting the relevant documentation parts.
• Adding missing documentation and @since tags in some classes.
• Renaming some variables to clarify that it is the object ID which is passed around, not the object itself.

Follow-up to [760/tests], [838/tests], [922/tests], [948/tests], [985/tests], [27178], [32659], [34855], [37563], [40968], [44497], [46262].

See #56793.

File:

• trunk/tests/phpunit/tests/post/wpInsertPost.php (modified) (6 diffs)

trunk/tests/phpunit/tests/post/wpInsertPost.php

@@ -1193 +1193 @@
             )
         );
-        $this->assertSame( 0, $post_id );
+        $this->assertWPError( $post_id );
 
         $post_id = self::factory()->post->create(
@@ -1202 +1202 @@
             )
         );
-        $this->assertSame( 0, $post_id );
+        $this->assertWPError( $post_id );
 
         // Empty post_date_gmt without floating status
@@ -1211 +1211 @@
             )
         );
-        $this->assertSame( 0, $post_id );
+        $this->assertWPError( $post_id );
 
         $post_id = self::factory()->post->create(
@@ -1220 +1220 @@
             )
         );
-        $this->assertSame( 0, $post_id );
+        $this->assertWPError( $post_id );
 
         // Valid post_date_gmt
@@ -1229 +1229 @@
             )
         );
-        $this->assertSame( 0, $post_id );
+        $this->assertWPError( $post_id );
 
         // Invalid post_date_gmt
@@ -1238 +1238 @@
             )
         );
-        $this->assertSame( 0, $post_id );
+        $this->assertWPError( $post_id );
     }