Changeset 55020

Timestamp:

12/29/2022 03:31:22 PM (22 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in phpunit/includes/class-wp-unittest-factory-for-thing.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $function parameter to $callback in WP_UnitTest_Factory_For_Thing::callback().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:

• trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-thing.php (modified) (1 diff)

trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-thing.php

@@ -212 +212 @@
 
     /**
-     * Instantiates a callback objects for the given function name.
-     *
-     * @since UT (3.7.0)
-     *
-     * @param string $function The callback function.
+     * Instantiates a callback object for the given function name.
+     *
+     * @since UT (3.7.0)
+     *
+     * @param callable $callback The callback function.
      *
      * @return WP_UnitTest_Factory_Callback_After_Create
      */
-    public function callback( $function ) {
-        return new WP_UnitTest_Factory_Callback_After_Create( $function );
+    public function callback( $callback ) {
+        return new WP_UnitTest_Factory_Callback_After_Create( $callback );
     }