Changeset 55029 for trunk/tests/phpunit/tests/http/http.php

Timestamp:

01/05/2023 10:21:19 AM (21 months ago)

Author:

SergeyBiryukov

Message:

Tests: Bring some consistency to mocking HTTP requests in unit tests.

Includes:

• Renaming the $preempt parameter to $response in the pre_http_request filter to better match the context used in callbacks (returning the original value if the conditions are not met rather than preempting the request).
• Synchronizing parameter names and types in various pre_http_request callbacks in unit tests.

Follow-up to [34509], [37907], [40628], [40629], [45667], [46175], [48242], [48462], [49904], [51021], [51973], [52146], [52382], [54043], [54968].

See #56793, #56792.

File:

• trunk/tests/phpunit/tests/http/http.php (modified) (1 diff)

trunk/tests/phpunit/tests/http/http.php

@@ -585 +585 @@
         add_filter(
             'pre_http_request',
-            function( $response, $args, $url ) use ( &$pre_http_request_filter_has_run ) {
+            function( $response, $parsed_args, $url ) use ( &$pre_http_request_filter_has_run ) {
                 $pre_http_request_filter_has_run = true;