Changeset 55029 for trunk/tests/phpunit/tests/http/wpGetHttpHeaders.php

Timestamp:

01/05/2023 10:21:19 AM (22 months ago)

Author:

SergeyBiryukov

Message:

Tests: Bring some consistency to mocking HTTP requests in unit tests.

Includes:

• Renaming the $preempt parameter to $response in the pre_http_request filter to better match the context used in callbacks (returning the original value if the conditions are not met rather than preempting the request).
• Synchronizing parameter names and types in various pre_http_request callbacks in unit tests.

Follow-up to [34509], [37907], [40628], [40629], [45667], [46175], [48242], [48462], [49904], [51021], [51973], [52146], [52382], [54043], [54968].

See #56793, #56792.

File:

• trunk/tests/phpunit/tests/http/wpGetHttpHeaders.php (modified) (1 diff)

trunk/tests/phpunit/tests/http/wpGetHttpHeaders.php

@@ -45 +45 @@
      * Mock the HTTP request response
      *
-     * @param bool   $false     False.
-     * @param array  $arguments Request arguments.
-     * @param string $url       Request URL.
-     * @return array|bool
+     * @param false|array|WP_Error $response    A preemptive return value of an HTTP request. Default false.
+     * @param array                $parsed_args HTTP request arguments.
+     * @param string               $url         The request URL.
+     * @return false|array|WP_Error Response data.
      */
-    public function mock_http_request( $false, $arguments, $url ) {
+    public function mock_http_request( $response, $parsed_args, $url ) {
         if ( 'http://example.com' === $url ) {
             return array( 'headers' => true );
         }
 
-        return false;
+        return $response;
     }
 }