Changeset 55029 for trunk/tests/phpunit/tests/oembed/controller.php

Timestamp:

01/05/2023 10:21:19 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Bring some consistency to mocking HTTP requests in unit tests.

Includes:

• Renaming the $preempt parameter to $response in the pre_http_request filter to better match the context used in callbacks (returning the original value if the conditions are not met rather than preempting the request).
• Synchronizing parameter names and types in various pre_http_request callbacks in unit tests.

Follow-up to [34509], [37907], [40628], [40629], [45667], [46175], [48242], [48462], [49904], [51021], [51973], [52146], [52382], [54043], [54968].

See #56793, #56792.

File:

• trunk/tests/phpunit/tests/oembed/controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/oembed/controller.php

@@ -85 +85 @@
          * Intercept oEmbed requests and mock responses.
          *
-         * @param mixed  $preempt Whether to preempt an HTTP request's return value. Default false.
-         * @param mixed  $r       HTTP request arguments.
-         * @param string $url     The request URL.
+         * @param false|array|WP_Error $response    A preemptive return value of an HTTP request. Default false.
+         * @param array                $parsed_args HTTP request arguments.
+         * @param string               $url         The request URL.
          * @return array Response data.
          */
-        public function mock_embed_request( $preempt, $r, $url ) {
-                unset( $preempt, $r );
+        public function mock_embed_request( $response, $parsed_args, $url ) {
+                unset( $response, $parsed_args );
 
                 $parsed_url = wp_parse_url( $url );