Changeset 55029 for trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php

Timestamp:

01/05/2023 10:21:19 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Bring some consistency to mocking HTTP requests in unit tests.

Includes:

• Renaming the $preempt parameter to $response in the pre_http_request filter to better match the context used in callbacks (returning the original value if the conditions are not met rather than preempting the request).
• Synchronizing parameter names and types in various pre_http_request callbacks in unit tests.

Follow-up to [34509], [37907], [40628], [40629], [45667], [46175], [48242], [48462], [49904], [51021], [51973], [52146], [52382], [54043], [54968].

See #56793, #56792.

File:

• trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php

@@ -35 +35 @@
     }
 
-    public function mock_embed_request( $preempt, $r, $url ) {
-        unset( $preempt, $r );
+    public function mock_embed_request( $response, $parsed_args, $url ) {
+        unset( $response, $parsed_args );
 
         // Mock request to YouTube Embed.