Changeset 55029 for trunk/tests/phpunit/tests/rest-api/wpRestUrlDetailsController.php

Timestamp:

01/05/2023 10:21:19 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Bring some consistency to mocking HTTP requests in unit tests.

Includes:

• Renaming the $preempt parameter to $response in the pre_http_request filter to better match the context used in callbacks (returning the original value if the conditions are not met rather than preempting the request).
• Synchronizing parameter names and types in various pre_http_request callbacks in unit tests.

Follow-up to [34509], [37907], [40628], [40629], [45667], [46175], [48242], [48462], [49904], [51021], [51973], [52146], [52382], [54043], [54968].

See #56793, #56792.

File:

• trunk/tests/phpunit/tests/rest-api/wpRestUrlDetailsController.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/wpRestUrlDetailsController.php

@@ -1097 +1097 @@
          * @return array faux/mocked response.
          */
-        public function mock_success_request_to_remote_url( $response, $args ) {
-                return $this->mock_request_to_remote_url( 'success', $args );
-        }
-
-        public function mock_failed_request_to_remote_url( $response, $args ) {
-                return $this->mock_request_to_remote_url( 'failure', $args );
-        }
-
-        public function mock_request_to_remote_url_with_empty_body_response( $response, $args ) {
-                return $this->mock_request_to_remote_url( 'empty_body', $args );
-        }
-
-        private function mock_request_to_remote_url( $result_type, $args ) {
-                $this->request_args = $args;
+        public function mock_success_request_to_remote_url( $response, $parsed_args ) {
+                return $this->mock_request_to_remote_url( 'success', $parsed_args );
+        }
+
+        public function mock_failed_request_to_remote_url( $response, $parsed_args ) {
+                return $this->mock_request_to_remote_url( 'failure', $parsed_args );
+        }
+
+        public function mock_request_to_remote_url_with_empty_body_response( $response, $parsed_args ) {
+                return $this->mock_request_to_remote_url( 'empty_body', $parsed_args );
+        }
+
+        private function mock_request_to_remote_url( $result_type, $parsed_args ) {
+                $this->request_args = $parsed_args;
 
                 $types = array(