Changeset 55035

Timestamp:

01/06/2023 10:34:00 AM (23 months ago)

Author:

spacedmonkey

Message:

Query: Stop priming posts twice in WP_Query.

Part revert of [54352]. In cases where queries are not split, then it results in priming posts that are already loaded resulting in a superfluous database query.

Props spacedmonkey, flixos90, peterwilsoncc.
Fixes #57373.

Location:

trunk

Files:

• src/wp-includes/class-wp-query.php (modified) (1 diff)
• tests/phpunit/tests/post/nav-menu.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -3477 +3477 @@
 
             if ( $q['cache_results'] ) {
-                $post_ids = wp_list_pluck( $this->posts, 'ID' );
-                _prime_post_caches( $post_ids, $q['update_post_term_cache'], $q['update_post_meta_cache'] );
+                update_post_caches( $this->posts, $post_type, $q['update_post_term_cache'], $q['update_post_meta_cache'] );
             }
 

trunk/tests/phpunit/tests/post/nav-menu.php

@@ -299 +299 @@
         wp_get_nav_menu_items( $this->menu_id );
         $queries_made = get_num_queries() - $start_num_queries;
-        $this->assertSame( 7, $queries_made, 'Only does 7 database queries when running wp_get_nav_menu_items.' );
+        $this->assertSame( 6, $queries_made, 'Only does 6 database queries when running wp_get_nav_menu_items.' );
 
         $args = $action->get_args();
@@ -340 +340 @@
         wp_get_nav_menu_items( $this->menu_id );
         $queries_made = get_num_queries() - $start_num_queries;
-        $this->assertSame( 7, $queries_made, 'Only does 7 database queries when running wp_get_nav_menu_items.' );
+        $this->assertSame( 6, $queries_made, 'Only does 6 database queries when running wp_get_nav_menu_items.' );
 
         $args = $action_terms->get_args();