Changeset 55049

Timestamp:

01/11/2023 11:50:01 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/customize/nav-menus.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $type and $object parameters to $object_type and $object_name in Test_WP_Customize_Nav_Menus::filter_items().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038], [55039].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:

• trunk/tests/phpunit/tests/customize/nav-menus.php (modified) (1 diff)

trunk/tests/phpunit/tests/customize/nav-menus.php

@@ -58 +58 @@
      * Filter to add custom menu items.
      *
-     * @param array  $items  The menu items.
-     * @param string $type   The object type (e.g. taxonomy).
-     * @param string $object The object name (e.g. category).
+     * @param array  $items       The menu items.
+     * @param string $object_type The object type (e.g. taxonomy).
+     * @param string $object_name The object name (e.g. category).
      * @return array Menu items.
      */
-    public function filter_items( $items, $type, $object ) {
+    public function filter_items( $items, $object_type, $object_name ) {
         $items[] = array(
             'id'         => 'custom-1',
             'title'      => 'Cool beans',
-            'type'       => $type,
+            'type'       => $object_type,
             'type_label' => 'Custom Label',
-            'object'     => $object,
+            'object'     => $object_name,
             'url'        => home_url( '/cool-beans/' ),
             'classes'    => 'custom-menu-item cool-beans',