Make WordPress Core


Ignore:
Timestamp:
01/11/2023 12:21:41 PM (17 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/customize/setting.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $default parameter to $default_value in:

  • Tests_WP_Customize_Setting::custom_type_getter()
  • Tests_WP_Customize_Setting::custom_type_value_filter()

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038], [55039], [55049].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/customize/setting.php

    r54088 r55050  
    317317    protected $custom_type_data_previewed;
    318318
    319     private function custom_type_getter( $name, $default = null ) {
     319    private function custom_type_getter( $name, $default_value = null ) {
    320320        if ( did_action( "customize_preview_{$name}" ) && array_key_exists( $name, $this->custom_type_data_previewed ) ) {
    321321            $value = $this->custom_type_data_previewed[ $name ];
     
    323323            $value = $this->custom_type_data_saved[ $name ];
    324324        } else {
    325             $value = $default;
     325            $value = $default_value;
    326326        }
    327327        return $value;
     
    335335     * Filter for `customize_value_{$id_base}`.
    336336     *
    337      * @param mixed $default
     337     * @param mixed $default_value
    338338     * @param WP_Customize_Setting $setting
    339339     *
    340340     * @return mixed|null
    341341     */
    342     public function custom_type_value_filter( $default, $setting = null ) {
     342    public function custom_type_value_filter( $default_value, $setting = null ) {
    343343        $name = preg_replace( '/^customize_value_/', '', current_filter() );
    344344        $this->assertInstanceOf( 'WP_Customize_Setting', $setting );
    345345        $id_data = $setting->id_data();
    346346        $this->assertSame( $name, $id_data['base'] );
    347         return $this->custom_type_getter( $name, $default );
     347        return $this->custom_type_getter( $name, $default_value );
    348348    }
    349349
Note: See TracChangeset for help on using the changeset viewer.