Changeset 55053

Timestamp:

01/11/2023 03:21:18 PM (2 years ago)

Author:

flixos90

Message:

Formatting: Improve performance of esc_url().

This changeset indirectly improves performance of the commonly used esc_url() function by optimizing the low-level function wp_kses_bad_protocol() for the by far most common scenarios, which are URLs using either the http or https protocol.

For this common scenario, the changeset now avoids the do while loop. While for a single call to the esc_url() function the performance wins are negligible, given that esc_url() is often called many times in one page load, they can add up, making this a worthwhile improvement.

Props mukesh27, schlessera, markjaquith, azaozz, spacedmonkey.
Fixes #22951.

File:

• trunk/src/wp-includes/kses.php (modified) (1 diff)

trunk/src/wp-includes/kses.php

@@ -1687 +1687 @@
  */
 function wp_kses_bad_protocol( $content, $allowed_protocols ) {
-    $content    = wp_kses_no_null( $content );
+    $content = wp_kses_no_null( $content );
+
+    // Short-circuit if the string starts with `https://` or `http://`. Most common cases.
+    if (
+        ( str_starts_with( $content, 'https://' ) && in_array( 'https', $allowed_protocols, true ) ) ||
+        ( str_starts_with( $content, 'http://' ) && in_array( 'http', $allowed_protocols, true ) )
+    ) {
+        return $content;
+    }
+
     $iterations = 0;