Changeset 55055

Timestamp:

01/12/2023 12:17:45 AM (23 months ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Revert a temporary conditional for testing the Rollbacks feature project.

The ​Rollback Update Failure feature project has been split into two plugins for testing:

• ​Faster Updates speeds up plugin or theme updates by moving files rather than copying them, thus decreasing the memory usage and reducing the chance of timeouts or running out of disk space during updates.
• ​Rollback Update Failure creates a temporary backup of plugins and themes before updating. This aims to make the update process more reliable and ensure that if a plugin or theme update fails, the previous version can be safely restored.

The current priority of the feature project is to test the new move_dir() function, which offers better performance than copy_dir(). Instead of copying a directory in a recursive manner file by file from one location to another, move_dir() uses the rename() PHP function to speed up the process, which is instrumental in updating large plugins without a delay. If the renaming failed, it falls back to the copy_dir() WP function.

The move_dir() function is self-contained in the Faster Updates plugin and does not require any special hooks in core, so the conditional previously added to WP_Upgrader::install_package() to facilitate testing is no longer needed and can be removed.

Follow-up to [53578], [54484], [54643].

Props afragen, costdev, peterwilsoncc.
See #56057, #57375, #57386.

File:

• trunk/src/wp-admin/includes/class-wp-upgrader.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-upgrader.php

@@ -595 +595 @@
 
         // Copy new version of item into place.
-        if ( class_exists( 'Rollback_Update_Failure\WP_Upgrader' )
-            && function_exists( '\Rollback_Update_Failure\move_dir' )
-        ) {
-            /*
-             * If the {@link https://wordpress.org/plugins/rollback-update-failure/ Rollback Update Failure}
-             * feature plugin is installed, use the move_dir() function from there for better performance.
-             * Instead of copying a directory from one location to another, it uses the rename() PHP function
-             * to speed up the process. If the renaming failed, it falls back to copy_dir().
-             *
-             * This condition aims to facilitate broader testing of the Rollbacks (temp backups) feature project.
-             * It is temporary, until the plugin is merged into core.
-             */
-            $result = \Rollback_Update_Failure\move_dir( $source, $remote_destination );
-        } else {
-            $result = copy_dir( $source, $remote_destination );
-        }
-
-        if ( is_wp_error( $result ) ) {
-            if ( $args['clear_working'] ) {
-                $wp_filesystem->delete( $remote_source, true );
-            }
-            return $result;
-        }
+        $result = copy_dir( $source, $remote_destination );
 
         // Clear the working folder?
         if ( $args['clear_working'] ) {
             $wp_filesystem->delete( $remote_source, true );
+        }
+
+        if ( is_wp_error( $result ) ) {
+            return $result;
         }