Changeset 55059 for trunk/src/wp-includes/nav-menu-template.php

Timestamp:

01/12/2023 11:23:01 PM (4 years ago)

Author:

azaozz

Message:

Menus: Compare $menu_item->ID and $menu_item->menu_item_parent as strings and avoid moidifying them. Plugins may change the ID to a string.

Props Chouby, peterwilsoncc, Chrystl, manooweb, azaozz.
Fixes #57169.

File:

• trunk/src/wp-includes/nav-menu-template.php (modified) (1 diff)

trunk/src/wp-includes/nav-menu-template.php

@@ -199 +199 @@
         $menu_items_with_children = array();
         foreach ( (array) $menu_items as $menu_item ) {
-                // Fix invalid `menu_item_parent`. See: https://core.trac.wordpress.org/ticket/56926.
-                if ( (int) $menu_item->ID === (int) $menu_item->menu_item_parent ) {
+                /*
+                 * Fix invalid `menu_item_parent`. See: https://core.trac.wordpress.org/ticket/56926.
+                 * Compare as strings. Plugins may change the ID to string.
+                 * To avoid modifying the object, use `strval()` rather than casting to (string).
+                 */
+                if ( strval( $menu_item->ID ) === strval( $menu_item->menu_item_parent ) ) {
                         $menu_item->menu_item_parent = 0;
                 }