Changeset 55064

Timestamp:

01/13/2023 02:36:11 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/formatting/sanitizeTrackbackUrls.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $break parameter to $separator in Tests_Formatting_SanitizeTrackbackUrls::test_sanitize_trackback_urls_with_multiple_urls().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038], [55039], [55049], [55050], [55060], [55062].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:

• trunk/tests/phpunit/tests/formatting/sanitizeTrackbackUrls.php (modified) (1 diff)

trunk/tests/phpunit/tests/formatting/sanitizeTrackbackUrls.php

@@ -9 +9 @@
     /**
      * @ticket 21624
-     * @dataProvider breaks
+     * @dataProvider separators
      */
-    public function test_sanitize_trackback_urls_with_multiple_urls( $break ) {
-        $this->assertSame( "http://example.com\nhttp://example.org", sanitize_trackback_urls( "http://example.com{$break}http://example.org" ) );
+    public function test_sanitize_trackback_urls_with_multiple_urls( $separator ) {
+        $this->assertSame(
+            "http://example.com\nhttp://example.org",
+            sanitize_trackback_urls( "http://example.com{$separator}http://example.org" )
+        );
     }
 
-    public function breaks() {
+    public function separators() {
         return array(
             array( "\r\n\t " ),