Changeset 55066 for trunk/tests/phpunit/tests/image/functions.php

Timestamp:

01/14/2023 02:06:02 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Move the test for wp_save_image_file() with a GD resource to a more appropriate place.

When passed a GD resource as $image, wp_save_image_file() should throw a deprecated argument notice:

Function wp_save_image_file was called with an argument that is deprecated since version 3.5.0!
$image needs to be a WP_Image_Editor object.

The test verifies that the notice is thrown as expected.

Includes:

• Removing the Tests_Functions_Deprecated class. It appears to be initially intended for testing deprecated functions or arguments, but this was later superseded by the @expectedDeprecated annotation.
• Removing a redundant test for wp_save_image_file() not throwing a deprecation notice when passed a WP_Image_Editor instance. This is already covered by test_wp_save_image_file(), which would fail if there is an unexpected deprecation notice.

Follow-up to [1061/tests], [25408], [25409], [53529].

See #56793.

File:

• trunk/tests/phpunit/tests/image/functions.php (modified) (1 diff)

trunk/tests/phpunit/tests/image/functions.php

@@ -326 +326 @@
 
                 return $data;
+        }
+
+        /**
+         * Tests that wp_save_image_file() throws a deprecated argument notice when passed a GD resource.
+         *
+         * @ticket 6821
+         * @expectedDeprecated wp_save_image_file
+         * @requires function imagejpeg
+         *
+         * @covers ::wp_save_image_file
+         */
+        public function test_wp_save_image_file_deprecated_argument_with_gd_resource() {
+                require_once ABSPATH . 'wp-admin/includes/image-edit.php';
+
+                // Call wp_save_image_file().
+                $file = wp_tempnam();
+                $img  = imagecreatefromjpeg( DIR_TESTDATA . '/images/canola.jpg' );
+                $ret  = wp_save_image_file( $file, $img, 'image/jpeg', 1 );
+
+                imagedestroy( $img );
+                unlink( $file );
+
+                $this->assertTrue( $ret, 'Image failed to save.' );
         }