Make WordPress Core

Changeset 55077


Ignore:
Timestamp:
01/16/2023 04:19:54 PM (17 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/functions/wpListPluck.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $list parameter to $input_list in Tests_Functions_wpListPluck::test_wp_list_pluck().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038], [55039], [55049], [55050], [55060], [55062], [55064], [55065], [55076].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/functions/wpListPluck.php

    r51668 r55077  
    196196     * @dataProvider data_test_wp_list_pluck
    197197     *
    198      * @param array      $list      List of objects or arrays.
    199      * @param int|string $field     Field from the object to place instead of the entire object
    200      * @param int|string $index_key Field from the object to use as keys for the new array.
    201      * @param array      $expected  Expected result.
    202      */
    203     public function test_wp_list_pluck( $list, $field, $index_key, $expected ) {
    204         $this->assertSameSetsWithIndex( $expected, wp_list_pluck( $list, $field, $index_key ) );
     198     * @param array      $input_list List of objects or arrays.
     199     * @param int|string $field      Field from the object to place instead of the entire object
     200     * @param int|string $index_key  Field from the object to use as keys for the new array.
     201     * @param array      $expected   Expected result.
     202     */
     203    public function test_wp_list_pluck( $input_list, $field, $index_key, $expected ) {
     204        $this->assertSameSetsWithIndex( $expected, wp_list_pluck( $input_list, $field, $index_key ) );
    205205    }
    206206
Note: See TracChangeset for help on using the changeset viewer.