Changeset 55099

Timestamp:

01/19/2023 02:11:08 PM (2 years ago)

Author:

swissspidy

Message:

I18N: Allow installing new translations when changing the user locale on the profile page.

Up until now, new translations could only be installed via Settings -> General.
When editing the user profile, one could only select locales that were already installed.

This change allows also installing new translations if the editing user has the necessary capabilities.

Props barryceelen, johnbillion, ocean90, swissspidy.
Fixes #38664.

Location:

trunk/src/wp-admin

Files:

• css/forms.css (modified) (1 diff)
• includes/user.php (modified) (1 diff)
• user-edit.php (modified) (4 diffs)

trunk/src/wp-admin/css/forms.css

@@ -1070 +1070 @@
 
 .settings-php .language-install-spinner,
-.options-general-php .language-install-spinner {
+.options-general-php .language-install-spinner,
+.user-edit-php .language-install-spinner,
+.profile-php .language-install-spinner {
     display: inline-block;
     float: none;

trunk/src/wp-admin/includes/user.php

@@ -120 +120 @@
             $locale = 'en_US';
         } elseif ( ! in_array( $locale, get_available_languages(), true ) ) {
-            $locale = '';
+            if ( current_user_can( 'install_languages' ) && wp_can_install_language_pack() ) {
+                if ( ! wp_download_language_pack( $locale ) ) {
+                    $locale = '';
+                }
+            } else {
+                $locale = '';
+            }
         }
 

trunk/src/wp-admin/user-edit.php

@@ -9 +9 @@
 /** WordPress Administration Bootstrap */
 require_once __DIR__ . '/admin.php';
+
+/** WordPress Translation Installation API */
+require_once ABSPATH . 'wp-admin/includes/translation-install.php';
 
 wp_reset_vars( array( 'action', 'user_id', 'wp_http_referer' ) );
@@ -346 +349 @@
                     </tr>
 
-                    <?php $languages = get_available_languages(); ?>
-                    <?php if ( $languages ) : ?>
+                    <?php
+                    $languages = get_available_languages();
+                    $can_install_translations = current_user_can( 'install_languages' ) && wp_can_install_language_pack();
+                    ?>
+                    <?php if ( $languages || $can_install_translations ) : ?>
                     <tr class="user-language-wrap">
                         <th scope="row">
@@ -365 +371 @@
                             wp_dropdown_languages(
                                 array(
-                                    'name'      => 'locale',
-                                    'id'        => 'locale',
-                                    'selected'  => $user_locale,
-                                    'languages' => $languages,
-                                    'show_available_translations' => false,
-                                    'show_option_site_default' => true,
+                                    'name'                        => 'locale',
+                                    'id'                          => 'locale',
+                                    'selected'                    => $user_locale,
+                                    'languages'                   => $languages,
+                                    'show_available_translations' => $can_install_translations,
+                                    'show_option_site_default'    => true,
                                 )
                             );
@@ -912 +918 @@
 </script>
 
+<script type="text/javascript">
+    jQuery( function( $ ) {
+        var languageSelect = $( '#locale' );
+        $( 'form' ).on( 'submit', function() {
+            // Don't show a spinner for English and installed languages,
+            // as there is nothing to download.
+            if ( ! languageSelect.find( 'option:selected' ).data( 'installed' ) ) {
+                $( '#submit', this ).after( '<span class="spinner language-install-spinner is-active" />' );
+            }
+        });
+    } );
+</script>
+
 <?php if ( isset( $application_passwords_list_table ) ) : ?>
     <script type="text/html" id="tmpl-new-application-password">