Changeset 55102 for trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

Timestamp:

01/19/2023 09:46:58 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correct additional_field_get_callback() parameters in some REST API tests.

The second parameter passed to get_callback in WP_REST_Controller::add_additional_fields_to_object() is the field name, not the request details.

Includes moving the get_callback and update_callback helper functions next to the tests they are used in.

Follow-up to [38832], [43768].

See #56793.

File:

• trunk/tests/phpunit/tests/rest-api/rest-users-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -2826 +2826 @@
         }
 
+        public function additional_field_get_callback( $object, $field_name ) {
+                return get_user_meta( $object['id'], $field_name, true );
+        }
+
+        public function additional_field_update_callback( $value, $user, $field_name ) {
+                if ( 'returnError' === $value ) {
+                        return new WP_Error( 'rest_invalid_param', 'Testing an error.', array( 'status' => 400 ) );
+                }
+                update_user_meta( $user->ID, $field_name, $value );
+        }
+
         /**
          * @ticket 39701
@@ -3073 +3084 @@
         }
 
-        public function additional_field_get_callback( $object ) {
-                return get_user_meta( $object['id'], 'my_custom_int', true );
-        }
-
-        public function additional_field_update_callback( $value, $user ) {
-                if ( 'returnError' === $value ) {
-                        return new WP_Error( 'rest_invalid_param', 'Testing an error.', array( 'status' => 400 ) );
-                }
-                update_user_meta( $user->ID, 'my_custom_int', $value );
-        }
-
         protected function check_user_data( $user, $data, $context, $links ) {
                 $this->assertSame( $user->ID, $data['id'] );