Changeset 55105

Timestamp:

01/20/2023 01:34:41 AM (20 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Use correct property in IXR_Message::tag_open().

The IXR_Message class declares a property _currentTag, which is never assigned or used. It does assign to currentTag instead, which outside of that one assignment is never used either.

Since there are various other underscore-prefixed properties declared on the class, including one named _currentTagContents which is used in several places, it appears that the declared property is correct and the assignment is a typo.

This commit resolves a notice on PHP 8.2:

Deprecated: Creation of dynamic property IXR_Message::$currentTag is deprecated

Follow-up to [1346].

Props bjorsch, kraftbj, jrf, mukesh27, SergeyBiryukov.
See #56790.

Location:

trunk

Files:

• src/wp-includes/IXR/class-IXR-message.php (modified) (1 diff)
• tests/phpunit/tests/xmlrpc/message.php (added)

trunk/src/wp-includes/IXR/class-IXR-message.php

@@ -145 +145 @@
     {
         $this->_currentTagContents = '';
-        $this->currentTag = $tag;
+        $this->_currentTag = $tag;
         switch($tag) {
             case 'methodCall':