Changeset 55112

Timestamp:

01/22/2023 12:15:14 AM (20 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/pluggable/signatures.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $function parameter to $function_name in Tests_Pluggable_Signatures::test_pluggable_function_signatures_match().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038], [55039], [55049], [55050], [55060], [55062], [55064], [55065], [55076], [55077], [55078], [55081], [55090], [55100], [55104].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:

• trunk/tests/phpunit/tests/pluggable/signatures.php (modified) (1 diff)

trunk/tests/phpunit/tests/pluggable/signatures.php

@@ -16 +16 @@
      * @dataProvider get_defined_pluggable_functions
      */
-    public function test_pluggable_function_signatures_match( $function ) {
+    public function test_pluggable_function_signatures_match( $function_name ) {
 
         $signatures = $this->get_pluggable_function_signatures();
 
-        $this->assertTrue( function_exists( $function ) );
-        $this->assertArrayHasKey( $function, $signatures );
-
-        $function_ref = new ReflectionFunction( $function );
+        $this->assertTrue( function_exists( $function_name ) );
+        $this->assertArrayHasKey( $function_name, $signatures );
+
+        $function_ref = new ReflectionFunction( $function_name );
         $param_refs   = $function_ref->getParameters();
 
-        $this->assertSame( count( $signatures[ $function ] ), count( $param_refs ) );
+        $this->assertSame( count( $signatures[ $function_name ] ), count( $param_refs ) );
 
         $i = 0;
 
-        foreach ( $signatures[ $function ] as $name => $value ) {
+        foreach ( $signatures[ $function_name ] as $name => $value ) {
 
             $param_ref = $param_refs[ $i ];