Make WordPress Core

Changeset 55116


Ignore:
Timestamp:
01/23/2023 12:10:28 PM (17 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/rest-api.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit:

  • Renames the $string parameter to $date in:
    • Tests_REST_API::test_rest_parse_date()
    • Tests_REST_API::test_rest_parse_date_force_utc()
  • Amends the $value and $valid parameters to $expected for consistency.

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038], [55039], [55049], [55050], [55060], [55062], [55064], [55065], [55076], [55077], [55078], [55081], [55090], [55100], [55104], [55112], [55115].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/rest-api.php

    r54339 r55116  
    844844     * @dataProvider jsonp_callback_provider
    845845     */
    846     public function test_jsonp_callback_check( $callback, $valid ) {
    847         $this->assertSame( $valid, wp_check_jsonp_callback( $callback ) );
     846    public function test_jsonp_callback_check( $callback, $expected ) {
     847        $this->assertSame( $expected, wp_check_jsonp_callback( $callback ) );
    848848    }
    849849
     
    876876     * @dataProvider rest_date_provider
    877877     */
    878     public function test_rest_parse_date( $string, $value ) {
    879         $this->assertEquals( $value, rest_parse_date( $string ) );
     878    public function test_rest_parse_date( $date, $expected ) {
     879        $this->assertEquals( $expected, rest_parse_date( $date ) );
    880880    }
    881881
     
    908908     * @dataProvider rest_date_force_utc_provider
    909909     */
    910     public function test_rest_parse_date_force_utc( $string, $value ) {
    911         $this->assertSame( $value, rest_parse_date( $string, true ) );
     910    public function test_rest_parse_date_force_utc( $date, $expected ) {
     911        $this->assertSame( $expected, rest_parse_date( $date, true ) );
    912912    }
    913913
Note: See TracChangeset for help on using the changeset viewer.