Changeset 55129 for trunk/src/wp-includes/class-wp-theme-json.php

Timestamp:

01/24/2023 03:43:53 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/class-wp-theme-json.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $default parameter to $default_value in WP_Theme_JSON::get_metadata_boolean().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277], [53281], [53283], [53284], [53285], [53287], [53364], [53365], [54927], [54929], [54930], [54931], [54932], [54933], [54938], [54943], [54944], [54945], [54946], [54947], [54948], [54950], [54951], [54952], [54956], [54959], [54960], [54961], [54962], [54964], [54965], [54969], [54970], [54971], [54972], [54996], [55000], [55011], [55013], [55014], [55015], [55016], [55017], [55020], [55021], [55023], [55027], [55028], [55034], [55036], [55037], [55038], [55039], [55049], [55050], [55060], [55062], [55064], [55065], [55076], [55077], [55078], [55081], [55090], [55100], [55104], [55112], [55115], [55116], [55117], [55119], [55120], [55126], [55127].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:

• trunk/src/wp-includes/class-wp-theme-json.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-theme-json.php

@@ -2312 +2312 @@
          * @since 6.0.0
          *
-         * @param array      $data    The data to inspect.
-         * @param bool|array $path    Boolean or path to a boolean.
-         * @param bool       $default Default value if the referenced path is missing.
-         *                            Default false.
+         * @param array      $data          The data to inspect.
+         * @param bool|array $path          Boolean or path to a boolean.
+         * @param bool       $default_value Default value if the referenced path is missing.
+         *                                  Default false.
          * @return bool Value of boolean metadata.
          */
-        protected static function get_metadata_boolean( $data, $path, $default = false ) {
+        protected static function get_metadata_boolean( $data, $path, $default_value = false ) {
                 if ( is_bool( $path ) ) {
                         return $path;
@@ -2330 +2330 @@
                 }
 
-                return $default;
+                return $default_value;
         }