Changeset 55130

Timestamp:

01/24/2023 03:53:46 PM (21 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/functions/wpRefererField.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $echo parameter to $display in Tests_Functions_wpRefererField::test_wp_referer_field_should_respect_display_arg().

Follow-up to [54420], [54929].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:

• trunk/tests/phpunit/tests/functions/wpRefererField.php (modified) (2 diffs)

trunk/tests/phpunit/tests/functions/wpRefererField.php

@@ -31 +31 @@
 
     /**
-     * Tests that the echo argument is respected.
+     * Tests that the display argument is respected.
      *
      * @ticket 54106
      *
-     * @dataProvider data_wp_referer_field_should_respect_echo_arg
+     * @dataProvider data_wp_referer_field_should_respect_display_arg
      *
-     * @param mixed $echo Whether to echo or return the referer field.
+     * @param mixed $display Whether to echo or return the referer field.
      */
-    public function test_wp_referer_field_should_respect_echo_arg( $echo ) {
-        $actual = $echo ? get_echo( 'wp_referer_field' ) : wp_referer_field( false );
+    public function test_wp_referer_field_should_respect_display_arg( $display ) {
+        $actual = $display ? get_echo( 'wp_referer_field' ) : wp_referer_field( false );
 
         $this->assertSame( '<input type="hidden" name="_wp_http_referer" value="" />', $actual );
@@ -46 +46 @@
 
     /**
-     * Data provider for test_wp_referer_field_should_respect_echo_arg().
+     * Data provider for test_wp_referer_field_should_respect_display_arg().
      *
      * @return array
      */
-    public function data_wp_referer_field_should_respect_echo_arg() {
+    public function data_wp_referer_field_should_respect_display_arg() {
         return array(
             'true'         => array( true ),