Changeset 55131

Timestamp:

01/24/2023 04:03:26 PM (20 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in phpunit/tests/kses.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $global parameter to $global_name in Tests_Kses::test_kses_globals_are_defined().

Follow-up to [52229], [54203], [55090].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #56788.

File:

• trunk/tests/phpunit/tests/kses.php (modified) (3 diffs)

trunk/tests/phpunit/tests/kses.php

@@ -2093 +2093 @@
      * @ticket 54060
      *
-     * @param string $global The name of the global variable.
-     */
-    public function test_kses_globals_are_defined( $global ) {
-        $this->assertArrayHasKey( $global, $GLOBALS );
+     * @param string $global_name The name of the global variable.
+     */
+    public function test_kses_globals_are_defined( $global_name ) {
+        $this->assertArrayHasKey( $global_name, $GLOBALS );
     }
 
@@ -2105 +2105 @@
      */
     public function data_kses_globals_are_defined() {
-        $globals = array(
+        $required_kses_globals = array(
             'allowedposttags',
             'allowedtags',
@@ -2112 +2112 @@
         );
 
-        return $this->text_array_to_dataprovider( $globals );
+        return $this->text_array_to_dataprovider( $required_kses_globals );
     }
 }