Changeset 55134

Timestamp:

01/24/2023 09:11:47 PM (23 months ago)

Author:

audrasjb

Message:

Code Modernization: Fix a JS error in wpdialog.

This changeset replaces this.element._trigger('focus'); with this.element.trigger('focus'); in wpdialog to fix a JS error introduced in [55052].

Indeed, this inside the open() function of wpdialog refers to the jQuery UI widget, whereas this.element is the jQuery object of the DOM element. Thus, native jQuery methods need to be used, as _trigger is only defined on the jQuery UI widget.

Follow-up to [55052].

Props TobiasBg, audrasjb, shubham1gupta.
Fixes #56830.

File:

• trunk/src/js/_enqueues/lib/dialog.js (modified) (1 diff)

trunk/src/js/_enqueues/lib/dialog.js

@@ -18 +18 @@
 
             // WebKit leaves focus in the TinyMCE editor unless we shift focus.
-            this.element._trigger('focus');
+            this.element.trigger('focus');
             this._trigger('refresh');
         }