Changeset 55141

Timestamp:

01/25/2023 09:54:43 PM (2 years ago)

Author:

hellofromTonya

Message:

Editor: Remove WP_DEBUG defined check in wp_tinycolor_hue_to_rgb().

The constant WP_DEBUG is a default constant that is set within wp_initial_constants() when not defined. This means the constant will always be defined, thus making the defined( 'WP_DEBUG' ) unnecessary.

Removing the defined() provides these benefits:

• Makes the code more readable.
• Tiny performance optimization.

References:

• ​https://github.com/WordPress/gutenberg/pull/45979

Follow-up to [52049].

Props ocean90, spacedmonkey, mamaduka.
See #57527.

File:

• trunk/src/wp-includes/block-supports/duotone.php (modified) (2 diffs)

trunk/src/wp-includes/block-supports/duotone.php

@@ -460 +460 @@
     $svg = ob_get_clean();
 
-    if ( ! defined( 'SCRIPT_DEBUG' ) || ! SCRIPT_DEBUG ) {
+    if ( ! SCRIPT_DEBUG ) {
         // Clean up the whitespace.
         $svg = preg_replace( "/[\r\n\t ]+/", ' ', $svg );
@@ -544 +544 @@
     // !important is needed because these styles render before global styles,
     // and they should be overriding the duotone filters set by global styles.
-    $filter_style = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG
+    $filter_style = SCRIPT_DEBUG
         ? $selector . " {\n\tfilter: " . $filter_property . " !important;\n}\n"
         : $selector . '{filter:' . $filter_property . ' !important;}';