Changeset 55146 for trunk/tests/phpunit/tests/blocks/editor.php

Timestamp:

01/26/2023 06:37:47 PM (4 years ago)

Author:

flixos90

Message:

Themes: Avoid unnecessary database queries from get_default_block_editor_settings() in WP_Theme_JSON_Resolver::get_theme_data().

The get_default_block_editor_settings() function included several pieces of data that are irrelevant for the purpose that WP_Theme_JSON_Resolver was calling it for, yet resulted in three database queries on page load that can be avoided.

This changeset introduces a new function get_classic_theme_supports_block_editor_settings() to takes responsibility of only the data needed in WP_Theme_JSON_Resolver, which now uses that function. This leads to a reduction of database queries and accordingly a performance improvement.

Props mamaduka, spacedmonkey, oandregal, flixos90, audrasjb, mukesh27.
Fixes #57547.

File:

• trunk/tests/phpunit/tests/blocks/editor.php (modified) (1 diff)

trunk/tests/phpunit/tests/blocks/editor.php

@@ -570 +570 @@
 
         /**
+         * @ticket 57547
+         *
+         * @covers ::get_classic_theme_supports_block_editor_settings
+         */
+        public function test_get_classic_theme_supports_block_editor_settings() {
+                $font_sizes = array(
+                        array(
+                                'name' => 'Small',
+                                'size' => 12,
+                                'slug' => 'small',
+                        ),
+                        array(
+                                'name' => 'Regular',
+                                'size' => 16,
+                                'slug' => 'regular',
+                        ),
+                );
+
+                add_theme_support( 'editor-font-sizes', $font_sizes );
+                $settings = get_classic_theme_supports_block_editor_settings();
+                remove_theme_support( 'editor-font-sizes' );
+
+                $this->assertFalse( $settings['disableCustomColors'], 'Value for array key "disableCustomColors" does not match expectations' );
+                $this->assertFalse( $settings['disableCustomFontSizes'], 'Value for array key "disableCustomFontSizes" does not match expectations' );
+                $this->assertFalse( $settings['disableCustomGradients'], 'Value for array key "disableCustomGradients" does not match expectations' );
+                $this->assertFalse( $settings['disableLayoutStyles'], 'Value for array key "disableLayoutStyles" does not match expectations' );
+                $this->assertFalse( $settings['enableCustomLineHeight'], 'Value for array key "enableCustomLineHeight" does not match expectations' );
+                $this->assertFalse( $settings['enableCustomSpacing'], 'Value for array key "enableCustomSpacing" does not match expectations' );
+                $this->assertFalse( $settings['enableCustomUnits'], 'Value for array key "enableCustomUnits" does not match expectations' );
+
+                $this->assertSame(
+                        $font_sizes,
+                        $settings['fontSizes'],
+                        'Value for array key "fontSizes" does not match expectations'
+                );
+        }
+
+        /**
          * Data provider.
          *