Changeset 55146 for trunk/tests/phpunit/tests/theme/wpThemeJson.php

Timestamp:

01/26/2023 06:37:47 PM (4 years ago)

Author:

flixos90

Message:

Themes: Avoid unnecessary database queries from get_default_block_editor_settings() in WP_Theme_JSON_Resolver::get_theme_data().

The get_default_block_editor_settings() function included several pieces of data that are irrelevant for the purpose that WP_Theme_JSON_Resolver was calling it for, yet resulted in three database queries on page load that can be avoided.

This changeset introduces a new function get_classic_theme_supports_block_editor_settings() to takes responsibility of only the data needed in WP_Theme_JSON_Resolver, which now uses that function. This leads to a reduction of database queries and accordingly a performance improvement.

Props mamaduka, spacedmonkey, oandregal, flixos90, audrasjb, mukesh27.
Fixes #57547.

File:

• trunk/tests/phpunit/tests/theme/wpThemeJson.php (modified) (3 diffs)

trunk/tests/phpunit/tests/theme/wpThemeJson.php

@@ -2646 +2646 @@
         public function test_get_editor_settings_custom_units_can_be_disabled() {
                 add_theme_support( 'custom-units', array() );
-                $actual = WP_Theme_JSON::get_from_editor_settings( get_default_block_editor_settings() );
+                $actual = WP_Theme_JSON::get_from_editor_settings( get_classic_theme_supports_block_editor_settings() );
                 remove_theme_support( 'custom-units' );
 
@@ -2663 +2663 @@
         public function test_get_editor_settings_custom_units_can_be_enabled() {
                 add_theme_support( 'custom-units' );
-                $actual = WP_Theme_JSON::get_from_editor_settings( get_default_block_editor_settings() );
+                $actual = WP_Theme_JSON::get_from_editor_settings( get_classic_theme_supports_block_editor_settings() );
                 remove_theme_support( 'custom-units' );
 
@@ -2680 +2680 @@
         public function test_get_editor_settings_custom_units_can_be_filtered() {
                 add_theme_support( 'custom-units', 'rem', 'em' );
-                $actual = WP_Theme_JSON::get_from_editor_settings( get_default_block_editor_settings() );
+                $actual = WP_Theme_JSON::get_from_editor_settings( get_classic_theme_supports_block_editor_settings() );
                 remove_theme_support( 'custom-units' );