Changeset 55154 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php

Timestamp:

01/27/2023 10:01:59 PM (20 months ago)

Author:

adamsilverstein

Message:

Revisions: only create autosave when content changed.

In the autosave REST API endpoint, avoid excessive database writes when an autosave is sent with content that is unchanged from the saved post.

Before this fix, clicking "preview" in the editor (which uses the autosave feature) multiple times would cause an identical autosave entry to be deleted and re-created repeatedly.

Props inwerpsel, aduth, mukesh27, ironprogrammer.
Fixes #49532.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php

@@ -361 +361 @@
         }
 
+        // Only create an autosave when it is different from the saved post.
+        $autosave_is_different = false;
+        $new_autosave          = _wp_post_revision_data( $post_data, true );
+
+        foreach ( array_intersect( array_keys( $new_autosave ), array_keys( _wp_post_revision_fields( $post ) ) ) as $field ) {
+            if ( normalize_whitespace( $new_autosave[ $field ] ) !== normalize_whitespace( $post->$field ) ) {
+                $autosave_is_different = true;
+                break;
+            }
+        }
+
+        if ( ! $autosave_is_different ) {
+            return new WP_Error(
+                'rest_autosave_no_changes',
+                __( 'There is nothing to save. The autosave and the post content are the same.' ),
+                array( 'status' => 400 )
+            );
+        }
+
         $user_id = get_current_user_id();
 
@@ -367 +386 @@
 
         if ( $old_autosave ) {
-            $new_autosave                = _wp_post_revision_data( $post_data, true );
             $new_autosave['ID']          = $old_autosave->ID;
             $new_autosave['post_author'] = $user_id;
-
-            // If the new autosave has the same content as the post, delete the autosave.
-            $autosave_is_different = false;
-
-            foreach ( array_intersect( array_keys( $new_autosave ), array_keys( _wp_post_revision_fields( $post ) ) ) as $field ) {
-                if ( normalize_whitespace( $new_autosave[ $field ] ) !== normalize_whitespace( $post->$field ) ) {
-                    $autosave_is_different = true;
-                    break;
-                }
-            }
-
-            if ( ! $autosave_is_different ) {
-                wp_delete_post_revision( $old_autosave->ID );
-                return new WP_Error(
-                    'rest_autosave_no_changes',
-                    __( 'There is nothing to save. The autosave and the post content are the same.' ),
-                    array( 'status' => 400 )
-                );
-            }
 
             /** This filter is documented in wp-admin/post.php */